Thread (2 messages) 2 messages, 2 authors, 2012-02-15

Re: [PATCH v2] Return proper error code from register_kprobe()

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2012-02-15 21:23:16
Also in: lkml

On Wed, 15 Feb 2012 12:46:03 +0530
Prashanth Nageshappa [off-list ref] wrote:
register_kprobe() aborts if the address of the new request falls in a
prohibited area (such as ftrace pouch, __kprobes annotated functions,
I'm sitting here wondering what you meant to type when you typed
"ftrace pouch".  I'm stumped!  But you're not allowed to tell us - that
would take all the fun out of it.
non-kernel text addresses, jump label text). We however don't return the
right error on this abort, resulting in a silent failure - incorrect 
adding/reporting of kprobes ('perf probe do_fork+18' or
'perf probe mcount' for instance).

In V2 we are incorporating Masami Hiramatsu's  feedback.

This patch fixes it by returning -EINVAL upon failure.

While we are here, rename the label used for exit to be more appropriate.

Signed-off-by: Ananth N Mavinakayanahalli <redacted>
Signed-off-by: Prashanth K Nageshappa <redacted>
Cc: stable@vger.kernel.org
So we want this for 3.3 with a -stable backport.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help