Thread (3 messages) 3 messages, 2 authors, 2012-02-07

Re: [PATCH 02/91] slub: fix panic with DISCONTIGMEM

From: David Rientjes <rientjes@google.com>
Date: 2012-02-06 21:59:11
Also in: lkml

On Sun, 5 Feb 2012, Willy Tarreau wrote:
commit 4a5fa3590f09999f6db41bc386bce40848fa9f63 upstream.

Slub makes assumptions about page_to_nid() which are violated by
DISCONTIGMEM and !NUMA.  This violation results in a panic because
page_to_nid() can be non-zero for pages in the discontiguous ranges and
this leads to a null return by get_node().  The assertion by the
maintainer is that DISCONTIGMEM should only be allowed when NUMA is also
defined.  However, at least six architectures: alpha, ia64, m32r, m68k,
mips, parisc violate this.  The panic is a regression against slab, so
just mark slub broken in the problem configuration to prevent users
reporting these panics.

Acked-by: David Rientjes <rientjes@google.com>
Acked-by: Pekka Enberg <penberg@kernel.org>
Signed-off-by: James Bottomley <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
The problem that this patch initially addressed is fixed by the next patch 
in your series, "set memory ranges in N_NORMAL_MEMORY when onlined", so I 
don't think this one should be merged.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help