Re: [PATCH 55/91] Make scsi_free_queue() kill pending SCSI commands

From: Willy Tarreau <w@1wt.eu>
Date: 2012-02-06 07:37:11
Also in: lkml

On Mon, Feb 06, 2012 at 08:28:48AM +0100, Bart Van Assche wrote:

On Sun, Feb 5, 2012 at 11:10 PM, Willy Tarreau [off-list ref] wrote:

quoted

2.6.27-longterm review patch. ï¿½If anyone has any objections, please let us know.

------------------

commit 3308511c93e6ad0d3c58984ecd6e5e57f96b12c8 upstream.

Make sure that SCSI device removal via scsi_remove_host() does finish
all pending SCSI commands. Currently that's not the case and hence
removal of a SCSI host during I/O can cause a deadlock. See also
"blkdev_issue_discard() hangs forever if underlying storage device is
removed" (http://bugzilla.kernel.org/show_bug.cgi?id=40472). See also
http://lkml.org/lkml/2011/8/27/6.

If you backport that commit, you should backport commit
745718132c3c7cac98a622b610e239dcd5217f71 too. See e.g.
http://lkml.org/lkml/2011/11/8/22.

Thank you Bart, I thought it was just cosmetic. Queued now.

Cheers,
Willy

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help