Re: [PATCH] module: Remove module size limit
From: Sasha Levin <hidden>
Date: 2012-01-31 04:13:13
Also in:
lkml
Rusty, I'm not sure why git forgot to add the 'From' line, but if you do merge it please add: From: Sasha Levin <redacted> Thanks! On Mon, 2012-01-30 at 23:07 -0500, Sasha Levin wrote:
quoted hunk ↗ jump to hunk
Module size was limited to 64MB, this was legacy limitation due to vmalloc() which was removed a while ago. Limiting module size to 64MB is both pointless and affects real world use cases. Cc: Rusty Russell <redacted> Cc: Tim Abbott <redacted> Cc: stable@vger.kernel.org Signed-off-by: Sasha Levin <redacted> --- kernel/module.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)diff --git a/kernel/module.c b/kernel/module.c index 2c93276..3d56b6f 100644 --- a/kernel/module.c +++ b/kernel/module.c@@ -2380,8 +2380,7 @@ static int copy_and_check(struct load_info *info, return -ENOEXEC; /* Suck in entire file: we'll want most of it. */ - /* vmalloc barfs on "unusual" numbers. Check here */ - if (len > 64 * 1024 * 1024 || (hdr = vmalloc(len)) == NULL) + if ((hdr = vmalloc(len)) == NULL) return -ENOMEM; if (copy_from_user(hdr, umod, len) != 0) {
-- Sasha.