Thread (31 messages) 31 messages, 3 authors, 2012-01-24

[19/27] USB: cdc-wdm: fix misuse of logical operation in place of bitop

From: Greg KH <gregkh@suse.de>
Date: 2012-01-24 00:09:32
Also in: lkml

2.6.32-longterm review patch.  If anyone has any objections, please let me know.

------------------

From: David Sterba <redacted>

commit 0cdfb819b6a97e79c7a0aa0c471cd7000367103b upstream.

CC: Greg Kroah-Hartman <gregkh@suse.de>
CC: Oliver Neukum <oliver@neukum.org>
CC: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: David Sterba <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Bj��rn Mork <bjorn@mork.no>

---
 drivers/usb/class/cdc-wdm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/class/cdc-wdm.c
+++ b/drivers/usb/class/cdc-wdm.c
@@ -314,7 +314,7 @@ static ssize_t wdm_write
 	if (r < 0)
 		goto outnp;
 
-	if (!file->f_flags && O_NONBLOCK)
+	if (!(file->f_flags & O_NONBLOCK))
 		r = wait_event_interruptible(desc->wait, !test_bit(WDM_IN_USE,
 								&desc->flags));
 	else

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help