[01/48] mtdoops: fix the oops_page_used array size
From: Greg KH <gregkh@suse.de>
Date: 2012-01-16 18:48:45
Also in:
lkml
3.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Roman Tereshonkov <redacted> commit 556f063580db2953a7e53cd46b47724246320f60 upstream. The array of unsigned long pointed by oops_page_used is allocated by vmalloc which requires the size to be in bytes. BITS_PER_LONG is equal to 32. If we want to allocate memory for 32 pages with one bit per page then 32 / BITS_PER_LONG is equal to 1 byte that is 8 bits. To fix it we need to multiply the result by sizeof(unsigned long) equal to 4. Signed-off-by: Roman Tereshonkov <redacted> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <redacted> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/mtd/mtdoops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/mtd/mtdoops.c
+++ b/drivers/mtd/mtdoops.c@@ -369,7 +369,7 @@ static void mtdoops_notify_add(struct mt /* oops_page_used is a bit field */ cxt->oops_page_used = vmalloc(DIV_ROUND_UP(mtdoops_pages, - BITS_PER_LONG)); + BITS_PER_LONG) * sizeof(unsigned long)); if (!cxt->oops_page_used) { printk(KERN_ERR "mtdoops: could not allocate page array\n"); return;