[PATCH v4 07/14] drm/panic: Return from screen_user if display is too small
From: Thomas Zimmermann <tzimmermann@suse.de>
Date: 2026-09-09 09:00:01
Also in:
amd-gfx, dri-devel, imx, intel-gfx, intel-xe, linux-arm-kernel, linux-doc, linux-hyperv, linux-renesas-soc, nouveau, sashiko-reviews, virtualization
Subsystem:
drm drivers, drm drivers and misc gpu patches, drm panic, the rest · Maintainers:
David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Jocelyn Falempe, Javier Martinez Canillas, Linus Torvalds
Return an error if the display is too small to display at least a single character. If the panic handler cannot display any message it does at least not destroy the current output, which might help with identifying the problem. v4: - also check font height against scanout buffer (Jocelyn) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> --- drivers/gpu/drm/drm_panic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c
index f597ef04c5bc..b1cd5e5865a0 100644
--- a/drivers/gpu/drm/drm_panic.c
+++ b/drivers/gpu/drm/drm_panic.c@@ -486,7 +486,7 @@ static int draw_panic_screen_user(struct drm_scanout_buffer *sb, u32 fg_color, u struct drm_rect r_screen, r_logo, r_msg; unsigned int msg_width, msg_height; - if (!font) + if (!font || font->width > sb->width || font->height > sb->height) return -EINVAL; fg_color = drm_draw_color_from_xrgb8888(fg_color, sb->format->format);
@@ -560,7 +560,7 @@ static int draw_panic_screen_kmsg(struct drm_scanout_buffer *sb, u32 fg_color, u struct drm_panic_line line; int yoffset; - if (!font || font->width > sb->width) + if (!font || font->width > sb->width || font->height > sb->height) return -EINVAL; fg_color = drm_draw_color_from_xrgb8888(fg_color, sb->format->format);
--
2.55.0