RE: [oe-core][PATCH 1/1] libgpiod: modify RDEPENDS for ptest

-----Original Message-----
From: openembedded-core@lists.openembedded.org <openembedded-
core@lists.openembedded.org> On Behalf Of Joe Slater via
lists.openembedded.org
Sent: Wednesday, July 12, 2023 2:33 PM
To: openembedded-core@lists.openembedded.org
Cc: Slater, Joseph <redacted>; MacLeod, Randy
[off-list ref]
Subject: [oe-core][PATCH 1/1] libgpiod: modify RDEPENDS for ptest

From: Joe Slater <redacted>

The current use of RDEPENDS to add a dependency on bats results in the QA
warning/error

 lib32-libgpiod package lib32-libgpiod-ptest-dev - suspicious values
  'bats-dev' in RRECOMMENDS [multilib]

when building lib32-libgpiod with ptest not enabled.  We add the dependency
only if ptest is enabled.

Signed-off-by: Joe Slater <redacted>
---
 meta-oe/recipes-support/libgpiod/libgpiod.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/libgpiod/libgpiod.inc b/meta-oe/recipes-

support/libgpiod/libgpiod.inc
index a2d1f57a8b..cb19bc5fb8 100644

--- a/meta-oe/recipes-support/libgpiod/libgpiod.inc
+++ b/meta-oe/recipes-support/libgpiod/libgpiod.inc

@@ -34,7 +34,7 @@ FILES:${PN}-tools += " \  FILES:libgpiodcxx =

"${libdir}/libgpiodcxx.so.*"

 RRECOMMENDS:${PN}-ptest += "coreutils"
-RDEPENDS:${PN}-ptest += "bats"
+RDEPENDS:${PN}-ptest += "${@bb.utils.contains('PTEST_ENABLED', '1', 'bats',
'', d)}"

 do_install:append() {
     rm -f ${D}${bindir}/gpiod-test
--
2.25.1