Re: [OE-core] [PATCH 1/2] sstate.bbclass: exceptions on mirror fetcher is not fatal
From: Richard Purdie <hidden>
Date: 2021-10-30 21:35:00
On Sat, 2021-10-30 at 00:13 +0100, Jose Quaresma wrote:
quoted hunk ↗ jump to hunk
An exceptions in sstate_checkhashes sstate mirror fetcher is not fatal for the build and it can be a warning. If we can't check status in the fetcher we can assume that sstate file don't exist on the mirror and build it from sources, ignoring the sstate cache. Signed-off-by: Jose Quaresma <redacted> --- meta/classes/sstate.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass index 6e4eb09f8e..54d38ed42d 100644 --- a/meta/classes/sstate.bbclass +++ b/meta/classes/sstate.bbclass@@ -995,7 +995,7 @@ def sstate_checkhashes(sq_data, d, siginfo=False, currentcount=0, summary=True, missed.add(tid) bb.debug(2, "SState: Unsuccessful fetch test for %s (%s)" % (srcuri, e)) except Exception as e: - bb.error("SState: cannot test %s: %s" % (srcuri, e)) + bb.warn("SState: cannot test file %s from mirrors '%s': (%s)" % (srcuri, mirrors, e)) if len(tasklist) >= min_tasks: bb.event.fire(bb.event.ProcessProgress(msg, len(tasklist) - thread_worker.tasks.qsize()), d)
This has been discussed a bit before. Whilst the issue isn't fatal to the build I do think this should be an error and have bitbake return an exit code that there was an issue as there is something wrong somewhere if we're hitting this code path. As an example: https://autobuilder.yoctoproject.org/typhoon/#/builders/63/builds/4230/steps/15/logs/stdio which might have not shown up if it wasn't an error. Cheers, Richard