Thread (10 messages) 10 messages, 4 authors, 2021-10-28

RE: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

From: Teoh, Jay Shen <hidden>
Date: 2021-10-28 11:04:14

Hi Alex, you're right, sorry I get confused with the question just now. Yes, the entire string doesn't have to match, it's enough if the string is part of the error message. I will go ahead and send out a v2 patch.

Thanks,
Jay

From: openembedded-core@lists.openembedded.org <redacted> On Behalf Of Alexander Kanavin
Sent: Thursday, 28 October, 2021 6:37 PM
To: Teoh, Jay Shen <redacted>
Cc: Khem Raj <redacted>; Jose Quaresma <redacted>; OE-core <redacted>
Subject: Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

I think the whole line doesn't have to match, it's enough if the string is in it somewhere. You can verify by making the message even shorter, and checking that it still works.

Alex

On Thu, 28 Oct 2021 at 12:15, Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>> wrote:
"[drm] Cannot find any crtc or sizes",
"[drm] Cannot find any crtc or sizes - going 1024x768",

Both lines are covering difference case, the first line covers the case when no fallback size is set, and second line covers the case when fallback size is set.

Thanks,
Jay

From: Alexander Kanavin <alex.kanavin@gmail.com<mailto:alex.kanavin@gmail.com>>
Sent: Thursday, 28 October, 2021 6:10 PM
To: Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>>
Cc: Khem Raj <raj.khem@gmail.com<mailto:raj.khem@gmail.com>>; Jose Quaresma <quaresma.jose@gmail.com<mailto:quaresma.jose@gmail.com>>; OE-core <openembedded-core@lists.openembedded.org<mailto:openembedded-core@lists.openembedded.org>>
Subject: Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

But then you can remove the previous line, right?

Alex

On Thu, 28 Oct 2021 at 12:08, Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>> wrote:

-----Original Message-----
From: Khem Raj <raj.khem@gmail.com<mailto:raj.khem@gmail.com>>
Sent: Thursday, 28 October, 2021 12:17 AM
To: Jose Quaresma <quaresma.jose@gmail.com<mailto:quaresma.jose@gmail.com>>
Cc: Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>>; OE-core <openembedded-
core@lists.openembedded.org<mailto:core@lists.openembedded.org>>
Subject: Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in
common errors list

On Wed, Oct 27, 2021 at 2:24 AM Jose Quaresma <quaresma.jose@gmail.com<mailto:quaresma.jose@gmail.com>>
wrote:
quoted


Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>> escreveu no dia quarta,
27/10/2021 à(s) 10:12:
quoted
quoted
From: Teoh Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>>

Add the following line to common_errors list.

  [drm] Cannot find any crtc or sizes

This message is not harmful, it extended the coverage for drm error message.

Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>>
---
 meta/lib/oeqa/runtime/cases/parselogs.py | 1 +
 1 file changed, 1 insertion(+)
diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py
b/meta/lib/oeqa/runtime/cases/parselogs.py
quoted
quoted
index 2b8893d842..96da0b4f5c 100644
--- a/meta/lib/oeqa/runtime/cases/parselogs.py
+++ b/meta/lib/oeqa/runtime/cases/parselogs.py
@@ -32,6 +32,7 @@ common_errors = [
     "Failed to load module \"fbdev\"",
     "Failed to load module fbdev",
     "Failed to load module glx",
+    "[drm] Cannot find any crtc or sizes",
     "[drm] Cannot find any crtc or sizes - going 1024x768",

I think this one ^ can be removed
will the first entry cover the case when a fallback size is set ?
In that case, it won't cover it. That's why I am adding a new line to expand the coverage
quoted
quoted
     "_OSC failed (AE_NOT_FOUND); disabling ASPM",
     "Open ACPI failed (/var/run/acpid.socket) (No such file or directory)",
--
2.33.1



--
Best regards,

José Quaresma

  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help