On Tue, 2021-10-26 at 14:59 +0000, Peter Kjellerstedt wrote:

quoted

-----Original Message-----
From: openembedded-core@lists.openembedded.org <openembedded-
core@lists.openembedded.org> On Behalf Of Konrad Weihmann
Sent: den 26 oktober 2021 13:24
To: Martyn Welch <redacted>; OE-core
<openembedded-
core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v6 2/2] core-image.bbclass: add
default
IMAGE_QA_PROHIBIT_PATHS variable



On 26.10.21 13:21, Martyn Welch wrote:

quoted

Note to self - remember to reply to list...

-------- Forwarded Message --------
From: Martyn Welch <redacted>
To: Konrad Weihmann <redacted>
Subject: Re: [OE-core] [PATCH v6 2/2] core-image.bbclass: add
default
IMAGE_QA_PROHIBIT_PATHS variable
Date: Tue, 26 Oct 2021 12:12:11 +0100

On Tue, 2021-10-26 at 12:56 +0200, Konrad Weihmann wrote:

quoted

On 26.10.21 12:50, Martyn Welch wrote:

<snip>

quoted

quoted

quoted

quoted

+# IMAGE_QA_PROHIBITED_PATHS
+# Ensure images aren't including files in places that will
be used as mount points or that are
+# reserved for runtime data.
+IMAGE_QA_PROHIBITED_PATHS ?=
"/dev/pts/*:/media/*:/mnt/*:/proc/*:/run/*:/tmp/*:/var/run/*:
/var/tmp/*:/var/volatile/*"

I like the idea, but wouldn't make more sense to do that on a
package
level, as here the user is more or less left alone in guessing
where
the file actually does come from

I like that idea, however it would make to assumption that there
wasn't
any tweaks being made as part of image generation that would end
up
violating this. A quick check suggests the "build-appliance-
image_15.0.0.bb" image does this kind of thing in the core image
types.

As Alex just wrote, I might be beneficial to do both

quoted

Martyn

We have an alternative solution that hooks into the package QA. It 
focuses on directories that are supposed to be empty. In addition to 
failing the build if there are files in such a directory, it also 
allows to specify for each directory why it should be empty. We have 
used this, e.g., to mark common directories that have been renamed 
to give an indication of where the files were supposed to have been 
installed.

Do you want me to generalize this and send a patch for it?

Hi Peter,

It would be great if we could merge these approaches, i.e. have one way
to specify directories that need to be empty and test both as part of
package QA and also image QA.

I was just working on adding some package QA support to what I've had,
but can pause that.

Would you be able to provide show how you'd propose managing the
prohibited directories? I'll try and tweak the image QA stuff already
posted to fit that.

Martyn

//Peter


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#157397):
https://lists.openembedded.org/g/openembedded-core/message/157397
Mute This Topic: https://lists.openembedded.org/mt/86599458/6512429
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe:
https://lists.openembedded.org/g/openembedded-core/unsub [
martyn.welch@collabora.com]
-=-=-=-=-=-=-=-=-=-=-=-