Re: [PATCH v2] dl: Use "adr" assembler command to get proper load address on ARM
From: Lukasz Majewski <lukma@denx.de>
Date: 2021-10-26 13:52:40
Hi Joseph, Szabolcs
On Mon, 25 Oct 2021, Szabolcs Nagy via Libc-alpha wrote:quoted
ok, i think we need the patches upstream for that like https://sourceware.org/pipermail/libc-alpha/2015-November/066153.htmlThe AArch64 prelink support isn't in the upstream Yocto cross-prelink, and the version written by Samsung in 2015 and on the cross_prelink_aarch64 branch has various problems resulting in test failures, in my experience.
Ok.
I sent patches (on top of a merge of the upstream cross_prelink and cross_prelink_aarch64 branches) to the maintainer in May 2020 (the Yocto project mailing list doesn't accept email from non-subscribers, so won't have seen those patches), which made it work well enough to get clean prelink test results, but so far they haven't been committed to the upstream cross_prelink branch (or any other upstream branch). I've now made those available at https://github.com/jsm28/prelink (cross_prelink_aarch64_fixes branch).
So this branch shall be pulled by yocto's cross-prelink maintainer. Without it the cross-prelink doesn't support aarch64?
Note however that, like the original patches from Samsung, this version does indeed depend on a hack in _dl_tlsdesc_undefweak to work with TLS descriptors.
To properly solve this issue we shall: 1. For arm - Fix the cross-prelink (no patches available) or - Fix glibc (as proposed by Szabolcs) 2. For aarch64 - Try to upstream patches from Joseph to OE/Yocto's cross-prelink or - Fix glibc (if required) or - Do nothing (aarch64 will not be prelinked in OE/Yocto, which means that it will work correctly) Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Attachments
- (unnamed) [application/pgp-signature] 488 bytes