Re: [PATCH v2] dl: Use "adr" assembler command to get proper load address on ARM
From: Lukasz Majewski <lukma@denx.de>
Date: 2021-10-25 18:25:49
Hi Szabolcs,
The 10/25/2021 16:04, Lukasz Majewski wrote:quoted
quoted
quoted
quoted
Either fix the prelink tool not to prelink shared objects that do not have a dependency on libc.so.6, or fix the dynamic loader to work if prelinked on AArch64.Just for the correctness - both 64 and 32 bit ARMs are affected.last time i looked, prelinking did not support tlsdesc correctly so it is unusable for aarch64. does yocto/oe use prelinking on aarch64?I think yes - the USER_CLASSES ?= "buildstats image-prelink" is added by default to local.confok, i think we need the patches upstream for that like https://sourceware.org/pipermail/libc-alpha/2015-November/066153.html
Oh... I see.
quoted
quoted
quoted
quoted
I do not have a strong opinion.Thanks for your opinion. Let's wait for other community members opinions.i think fixing the arm load address computation makes sense (small extra cost of a relative reloc). i think the c code proposal i made in the thread is nicer than the old asm. (i'm happy to make the same change on aarch64 too if prelinking is used there, but i think that's broken.)+1since you have a prelink setup, can you prepare the arm and aarch64 patches?
I can prepare the patch - no problem. Beforehand, I would like to hear from the community if we do have a consensus about this solution...
(i suspect x86 would need the same fix, but probably prelink is not used there anymore..?)
I do assume that in yocto at least it would use prelink by default as well. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Attachments
- (unnamed) [application/pgp-signature] 488 bytes