Re: [OE-core] [PATCH] buildstats.bbclass: collect host data only when do_testimage fails
From: Richard Purdie <hidden>
Date: 2021-08-30 20:22:01
On Fri, 2021-08-27 at 15:32 -0400, Sakib Sajal wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Sakib Sajal <redacted> --- meta/classes/buildstats.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/meta/classes/buildstats.bbclass b/meta/classes/buildstats.bbclass index 0de605200a..874d30b292 100644 --- a/meta/classes/buildstats.bbclass +++ b/meta/classes/buildstats.bbclass@@ -250,7 +250,7 @@ python run_buildstats () { except subprocess.CalledProcessError as err: bb.warn("Failed to get rootfs size: %s" % err.output.decode('utf-8')) - elif isinstance(e, bb.build.TaskFailed): + elif isinstance(e, bb.build.TaskFailed) and e.task == "do_testimage": # Can have a failure before TaskStarted so need to mkdir here too bb.utils.mkdirhier(taskdir) write_task_data("failed", os.path.join(taskdir, e.task), e, d)
Doesn't this remove all failure handling rather than just host data? That probably isn't what we want and isn't what the commit message says. Cheers, Richard