Thread (3 messages) 3 messages, 2 authors, 2021-08-26

Re: [OE-core] [PATCH] python3-pluggy: upgrade 0.13.1 -> 1.0.0

From: Tim Orling <hidden>
Date: 2021-08-26 16:53:27

On Thu, Aug 26, 2021 at 9:12 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:
On Wed, 2021-08-25 at 20:28 +0000, Tim Orling wrote:
quoted
* All ptests pass on qemux86-64

pluggy 1.0.0 (2021-08-25)

Deprecations and Removals

    #116: Remove deprecated implprefix support. Decorate hook
        implementations using an instance of HookimplMarker instead.
The deprecation was announced in release 0.7.0.
    #120: Remove the deprecated proc argument to call_historic. Use
        result_callback instead, which has the same behavior. The
deprecation was announced in release 0.7.0.
    #265: Remove the _Result.result property. Use _Result.get_result()
        instead. Note that unlike result, get_result() raises the
exception if the hook raised. The deprecation was announced in release
0.6.0.
    #267: Remove official support for Python 3.4.
    #272: Dropped support for Python 2. Continue to use pluggy 0.13.x
        for Python 2 support.
    #308: Remove official support for Python 3.5.
    #313: The internal pluggy.callers, pluggy.manager and pluggy.hooks
        are now explicitly marked private by a _ prefix (e.g.
pluggy._callers). Only API exported by the top-level pluggy module is
considered public.
    #59: Remove legacy __multicall__ recursive hook calling system. The
       deprecation was announced in release 0.5.0.

Features

    #282: When registering a hookimpl which is declared as
        hookwrapper=True but whose function is not a generator
function, a PluggyValidationError exception is now raised.

    Previously this problem would cause an error only later, when
calling the hook.

    In the unlikely case that you have a hookwrapper that returns a
generator instead of yielding directly, for example:

    def my_hook_real_implementation(arg):
        print("before")
        yield
        print("after")

    @hookimpl(hookwrapper=True)
    def my_hook(arg):
        return my_hook_implementation(arg)

    change it to use yield from instead:

    @hookimpl(hookwrapper=True)
    def my_hook(arg):
        yield from my_hook_implementation(arg)

    #309: Add official support for Python 3.9.

Signed-off-by: Tim Orling <redacted>
---
 .../{python3-pluggy_0.13.1.bb => python3-pluggy_1.0.0.bb}      | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
 rename meta/recipes-devtools/python/{python3-pluggy_0.13.1.bb =>
python3-pluggy_1.0.0.bb} (80%)

I haven't proof but I suspect this has caused python3-jinja2's ptests to
regress:


https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/2433/steps/12/logs/stdio

https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/2152/steps/12/logs/stdio

I didn't spot this before it merged unfortunately.
Replicated locally. Looking into fix.
Cheers,

Richard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help