Re: [OE-core][PATCH] flex: correct license information

Hi,

LICENSE set in flex recipe looks as not correct. It is set as "BSD-2-Clause" since:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-devtools/flex?id=fb8613fc4ed361c953087207b34b97ca23a8d4e4&h=dunfell.

however per reviewing the sources - correct LICENSE-s for flex packages should be:

LICENSE = "BSD-3-Clause & LGPL-2.0+"
LICENSE_${PN}-libfl = "BSD-3-Clause"

"BSD-3-Clause" is explained by top-level COPYING file in flex source-tree (https://github.com/westes/flex/blob/v2.6.4/COPYING#L27).
 *  text does actually include third obligation (without the actual "3" numbering)
"LGPL-2.0+" is explained by src/gettext.h (https://github.com/westes/flex/blob/v2.6.4/src/gettext.h#L4)
 *  relevant for flex but not flex-libfl package (that is not utilizing gettext)

Can this be approved and if yes - can we expect this update to be upstreamed (including dunfell branch)?

Thanks in advance,
Nikolay

----- Original Message -----
From: "Nikolay Papenkov" <redacted>
To: openembedded-core@lists.openembedded.org
Cc: "richard purdie" <redacted>, "Nikolay Papenkov" <redacted>, "Dmitry Kisil" <redacted>
Sent: Tuesday, May 25, 2021 2:23:26 PM
Subject: [OE-core][PATCH] flex: correct license information

License-Update: Corrected license information

flex package is under two licenses:
- "BSD-3-Clause" is provided in top-level COPYING file; the license
  actually include third obligation (without the actual "3" numbering)
- "LGPL-2.0+" is explained by src/gettext.h

Signed-off-by: Dmitry Kisil <redacted>
---
 meta/recipes-devtools/flex/flex_2.6.4.bb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/flex/flex_2.6.4.bb b/meta/recipes-devtools/flex/flex_2.6.4.bb
index 1d43d2228a..54e7e01729 100644
--- a/meta/recipes-devtools/flex/flex_2.6.4.bb
+++ b/meta/recipes-devtools/flex/flex_2.6.4.bb

@@ -3,12 +3,14 @@ DESCRIPTION = "Flex is a fast lexical analyser generator.  Flex is a tool for ge
 lexical patterns in text."
 HOMEPAGE = "http://sourceforge.net/projects/flex/"
 SECTION = "devel"
-LICENSE = "BSD-2-Clause"
+LICENSE = "BSD-3-Clause & LGPL-2.0+"
+LICENSE_${PN}-libfl = "BSD-3-Clause"
 
 DEPENDS = "${@bb.utils.contains('PTEST_ENABLED', '1', 'bison-native flex-native', '', d)}"
 BBCLASSEXTEND = "native nativesdk"
 
-LIC_FILES_CHKSUM = "file://COPYING;md5=e4742cf92e89040b39486a6219b68067"
+LIC_FILES_CHKSUM = "file://COPYING;md5=e4742cf92e89040b39486a6219b68067 \
+                    file://src/gettext.h;beginline=1;endline=17;md5=9c05dda2f58d89b850c399cf22e1a00c"
 
 SRC_URI = "https://github.com/westes/flex/releases/download/v${PV}/flex-${PV}.tar.gz \
            file://run-ptest \

-- 
2.17.1
-- 
Nikolay Papenkov


Inango. The Service Orchestrator. 
web. [ https://mail.inango.com/inango.com | inango.com ] 
mail. [ mailto:n.papenkov@inango-systems.com | n.papenkov@inango-systems.com ] 
tel. +357 99 615176