Thread (4 messages) 4 messages, 2 authors, 2021-04-01

Re: [OE-core][PATCH] apt: Fix do_compile error when enable ccache

From: Khem Raj <hidden>
Date: 2021-03-31 16:00:19


On 3/31/21 3:46 AM, Chen Qi wrote:
When apt was upgraded, the '-DCMAKE_DISABLE_FIND_PACKAGE_Zstd=True'
was dropped. However, it was there to fix do_compile error when ccache is
enabled. See details in the following commit.

"""
commit 0aa7d612b8b7e5f14b4ed38f2a32b3f7eefca31c
Author: Robert Yang [off-list ref]
Date:   Tue Jan 19 01:23:45 2021 -0800

     apt: Fix do_compile error when enable ccache

     Fixed:
         apt-pkg/libapt-pkg.so.5.0.2: undefined reference to `ZSTD_endStream'
	    collect2: error: ld returned 1 exit status

     This is because ccache-native depends on zstd-native which makes apt wronly
         find it. Disable zstd for apt to fix the problem.
"""
should this only be disabled for apt-native then ? and perhaps it could 
be turned into a packageconfig knob as well
quoted hunk ↗ jump to hunk
Now we are meeting do_compile failure again when enabling ccache, so add it
back to solve the problem.

Signed-off-by: Chen Qi <redacted>
---
  meta/recipes-devtools/apt/apt_2.2.2.bb | 1 +
  1 file changed, 1 insertion(+)
diff --git a/meta/recipes-devtools/apt/apt_2.2.2.bb b/meta/recipes-devtools/apt/apt_2.2.2.bb
index d1aa5de8df..7d1bce558d 100644
--- a/meta/recipes-devtools/apt/apt_2.2.2.bb
+++ b/meta/recipes-devtools/apt/apt_2.2.2.bb
@@ -44,6 +44,7 @@ DEPENDS += "db gnutls lz4 zlib bzip2 xz libgcrypt xxhash"
  EXTRA_OECMAKE_append = " -DCURRENT_VENDOR=debian -DWITH_DOC=False \
      -DDPKG_DATADIR=${datadir}/dpkg \
      -DTRIEHASH_EXECUTABLE=${WORKDIR}/triehash \
+    -DCMAKE_DISABLE_FIND_PACKAGE_ZSTD=True \
      -DWITH_TESTS=False \
  "
  



Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help