Re: [OE-core] [PATCH v2] toolchain-scripts.bbclass: customize prompt string for SDKs

On 2/26/21 7:02 PM, Richard Purdie wrote:

On Fri, 2021-02-26 at 09:57 +0800, Kai wrote:

quoted

On 2/25/21 11:29 PM, Christopher Larson wrote:
  

quoted

Are we sure we want to completely override it rather than adding
to it? I'd be rather irritated if this blows away my prompt
without my asking for it. I think either it should append or
have a variable controlling whether this is enabled when building
the SDK.

The original requirement is that the PS1 after source sdk environment
file is as same as the original one.
It can not tell whether in a sdk environment.

The default assignment of SDK_PS1 is '?=', you can set it in conf file to override it.

I've held off this patch for a while since I think its going to
*really* annoy a subset of users and as Chris says, it can't
be disabled. It would really need to be disablable through configuration
and at runtime when sourcing the script which isn't possible.

I appreciate the usability issue it is trying to improve but
I think it will cause more complaints than issues it solves.
As such I don't think we want to do this...

I have been working on the issue Chiris says by adding a check for 
SDK_PS1. If do not want to change the current behavior,
it could done by not set SDK_PS1 by default. It is better to have a 
chance to modify sdk prompt string.

Regards,
Kai

Cheers,

Richard

-- 
Kai Kang
Wind River Linux