Re: [PATCH] x264: add textrel to INSANE_SKIP
From: sujith h <hidden>
Date: 2016-09-26 09:31:26
On Mon, Sep 26, 2016 at 11:39 AM, sujith h [off-list ref] wrote:
Hi, Let me know if this patch is ok. Else I can help make this patch better.
oops, sorry for my earlier mail. This patch is merged : http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=aa7f7b63485b8c4d33491b9cd467fc4487a281c7
Thanks, Sujith H On Wed, Sep 21, 2016 at 3:12 PM, Sujith H [off-list ref] wrote:quoted
From: Fahad Usman <redacted> Tried by adding CFLAGS_append = " -fpic " to the recipe. But that couldn't help resolve the warning message: x264/r2491+gitAUTOINC+c8a773ebfc-r0/packages-split/x264/usr/lib/libx264.so.144' has relocations in .text [textrel] It was found that this warning is emitted because of the assembly files in the source code. And it is not easy to get rid of TEXTREL's which are coming from the assembly source files. Adding textrel to INSANE_SKIP resolves this issue. This issue was observed in cyclone5 and imx6qsabresd BSP's. So generalizing the patch. Signed-off-by: Fahad Usman <redacted> Signed-off-by: Sujith Haridasan <redacted> --- meta/recipes-multimedia/x264/x264_git.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/meta/recipes-multimedia/x264/x264_git.bbb/meta/recipes-multimedia/x264/x264_git.bb index fa44f9c..393310f 100644--- a/meta/recipes-multimedia/x264/x264_git.bb +++ b/meta/recipes-multimedia/x264/x264_git.bb@@ -48,6 +48,6 @@ do_install() { oe_runmake install DESTDIR=${D} } -# PIC can't be enabled for 32-bit x86 -INSANE_SKIP_${PN}_append_x86 = " textrel" +# PIC can't be enabled for few BSP's +INSANE_SKIP_${PN}_append = " textrel" --1.9.1-- സുജിത് ഹരിദാസന് Bangalore <Project>Contributor to KDE project <Project>Contributor to Yocto project http://fci.wikia.com/wiki/Anti-DRM-Campaign <Blog> http://sujithh.info C-x C-c
-- സുജിത് ഹരിദാസന് Bangalore <Project>Contributor to KDE project <Project>Contributor to Yocto project http://fci.wikia.com/wiki/Anti-DRM-Campaign <Blog> http://sujithh.info C-x C-c