Re: [PATCH 3/4] default-distrovars: Add empty weak definition for DISTRO variable
From: Khem Raj <hidden>
Date: 2012-02-24 17:14:32
On Fri, Feb 24, 2012 at 8:21 AM, Richard Purdie [off-list ref] wrote:
On Thu, 2012-02-23 at 19:33 -0800, Khem Raj wrote:quoted
Signed-off-by: Khem Raj <redacted> --- meta/conf/distro/include/default-distrovars.inc | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc index 16b3108..dba204e 100644 --- a/meta/conf/distro/include/default-distrovars.inc +++ b/meta/conf/distro/include/default-distrovars.inc@@ -41,6 +41,13 @@ NO32LIBS ??= "1"# Default to emitting logfiles if a build fails. BBINCLUDELOGS ??= "yes" + +# dummy distro related variables +# they should be overridden by real distros +# these fallbacks only serve the purpose of +# oe-core standalone testability + +DISTRO ??= "" SDK_VERSION ??= "oe-core.0" DISTRO_VERSION ??= "oe-core.0"Why do we need this? The commit message tells me what you're doing but not why. I'm really getting frustrated with one line commit messages with no details. I don't think we should need this either, I'm not sure I like the change. The whole idea was OE-Core could run "distroless".
There is an error case I dont remeber how I obtained that where it prints bogus value if DISTRO is not defined at all but and empty DISTRO var is distroless in essence anyway IMO
Cheers, Richard _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core