Re: [PATCH 14/29] fsdax: simplify the pgoff calculation

decouple DAX from block devices · Christoph Hellwig <hch@lst.de> · 2021-11-09
[PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem · Dan Williams <hidden> · 2021-11-17
Re: [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem · Christoph Hellwig <hch@lst.de> · 2021-11-19
Re: [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem · Dan Williams <hidden> · 2021-11-19
[PATCH 03/29] dax: remove CONFIG_DAX_DRIVER · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 03/29] dax: remove CONFIG_DAX_DRIVER · Dan Williams <hidden> · 2021-11-17
Re: [PATCH 03/29] dax: remove CONFIG_DAX_DRIVER · Dan Williams <hidden> · 2021-11-23
[PATCH 02/29] dm: make the DAX support dependend on CONFIG_FS_DAX · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 02/29] dm: make the DAX support dependend on CONFIG_FS_DAX · Dan Williams <hidden> · 2021-11-17
Re: [PATCH 02/29] dm: make the DAX support dependend on CONFIG_FS_DAX · Christoph Hellwig <hch@lst.de> · 2021-11-19
Re: [PATCH 02/29] dm: make the DAX support dependend on CONFIG_FS_DAX · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 02/29] dm: make the DAX support dependend on CONFIG_FS_DAX · Christoph Hellwig <hch@lst.de> · 2021-11-23
[PATCH 04/29] dax: simplify the dax_device <-> gendisk association · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 04/29] dax: simplify the dax_device <-> gendisk association · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 04/29] dax: simplify the dax_device <-> gendisk association · Christoph Hellwig <hch@lst.de> · 2021-11-23
Re: [PATCH 04/29] dax: simplify the dax_device <-> gendisk association · Dan Williams <hidden> · 2021-11-23
[PATCH 06/29] dax: move the partition alignment check into fs_dax_get_by_bdev · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 06/29] dax: move the partition alignment check into fs_dax_get_by_bdev · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 06/29] dax: move the partition alignment check into fs_dax_get_by_bdev · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 06/29] dax: move the partition alignment check into fs_dax_get_by_bdev · Christoph Hellwig <hch@lst.de> · 2021-11-24
[PATCH 05/29] dax: remove the pgmap sanity checks in generic_fsdax_supported · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 05/29] dax: remove the pgmap sanity checks in generic_fsdax_supported · Dan Williams <hidden> · 2021-11-23
[PATCH 08/29] dax: remove dax_capable · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 08/29] dax: remove dax_capable · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 08/29] dax: remove dax_capable · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 08/29] dax: remove dax_capable · Christoph Hellwig <hch@lst.de> · 2021-11-24
[PATCH 07/29] xfs: factor out a xfs_setup_dax_always helper · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 07/29] xfs: factor out a xfs_setup_dax_always helper · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-17
Re: [PATCH 07/29] xfs: factor out a xfs_setup_dax_always helper · Dan Williams <hidden> · 2021-11-23
[PATCH 09/29] dm-linear: add a linear_dax_pgoff helper · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 09/29] dm-linear: add a linear_dax_pgoff helper · Dan Williams <hidden> · 2021-11-23
[PATCH 10/29] dm-log-writes: add a log_writes_dax_pgoff helper · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 10/29] dm-log-writes: add a log_writes_dax_pgoff helper · Dan Williams <hidden> · 2021-11-23
[PATCH 13/29] fsdax: use a saner calling convention for copy_cow_page_dax · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 13/29] fsdax: use a saner calling convention for copy_cow_page_dax · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 13/29] fsdax: use a saner calling convention for copy_cow_page_dax · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
[PATCH 11/29] dm-stripe: add a stripe_dax_pgoff helper · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 11/29] dm-stripe: add a stripe_dax_pgoff helper · Dan Williams <hidden> · 2021-11-23
[PATCH 12/29] fsdax: remove a pointless __force cast in copy_cow_page_dax · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 12/29] fsdax: remove a pointless __force cast in copy_cow_page_dax · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 12/29] fsdax: remove a pointless __force cast in copy_cow_page_dax · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
[PATCH 16/29] fsdax: simplify the offset check in dax_iomap_zero · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 16/29] fsdax: simplify the offset check in dax_iomap_zero · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 16/29] fsdax: simplify the offset check in dax_iomap_zero · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
[PATCH 14/29] fsdax: simplify the pgoff calculation · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 14/29] fsdax: simplify the pgoff calculation · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 14/29] fsdax: simplify the pgoff calculation · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 14/29] fsdax: simplify the pgoff calculation · Christoph Hellwig <hch@lst.de> · 2021-11-24
[PATCH 15/29] xfs: add xfs_zero_range and xfs_truncate_page helpers · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 15/29] xfs: add xfs_zero_range and xfs_truncate_page helpers · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 15/29] xfs: add xfs_zero_range and xfs_truncate_page helpers · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
[PATCH 18/29] fsdax: decouple zeroing from the iomap buffered I/O code · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 18/29] fsdax: decouple zeroing from the iomap buffered I/O code · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 18/29] fsdax: decouple zeroing from the iomap buffered I/O code · Christoph Hellwig <hch@lst.de> · 2021-11-24
Re: [PATCH 18/29] fsdax: decouple zeroing from the iomap buffered I/O code · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 18/29] fsdax: decouple zeroing from the iomap buffered I/O code · Christoph Hellwig <hch@lst.de> · 2021-11-24
[PATCH 21/29] xfs: move dax device handling into xfs_{alloc,free}_buftarg · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 21/29] xfs: move dax device handling into xfs_{alloc,free}_buftarg · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 21/29] xfs: move dax device handling into xfs_{alloc,free}_buftarg · Dan Williams <hidden> · 2021-11-24
Re: [PATCH 21/29] xfs: move dax device handling into xfs_{alloc,free}_buftarg · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-24
Re: [PATCH 21/29] xfs: move dax device handling into xfs_{alloc,free}_buftarg · Christoph Hellwig <hch@lst.de> · 2021-11-24
[PATCH 17/29] fsdax: factor out a dax_memzero helper · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 17/29] fsdax: factor out a dax_memzero helper · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 17/29] fsdax: factor out a dax_memzero helper · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 17/29] fsdax: factor out a dax_memzero helper · Christoph Hellwig <hch@lst.de> · 2021-11-24
[PATCH 19/29] ext2: cleanup the dax handling in ext2_fill_super · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 19/29] ext2: cleanup the dax handling in ext2_fill_super · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 19/29] ext2: cleanup the dax handling in ext2_fill_super · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
[PATCH 22/29] iomap: add a IOMAP_DAX flag · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 22/29] iomap: add a IOMAP_DAX flag · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 22/29] iomap: add a IOMAP_DAX flag · Dan Williams <hidden> · 2021-11-24
Re: [PATCH 22/29] iomap: add a IOMAP_DAX flag · Christoph Hellwig <hch@lst.de> · 2021-11-24
[PATCH 20/29] ext4: cleanup the dax handling in ext4_fill_super · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 20/29] ext4: cleanup the dax handling in ext4_fill_super · Dan Williams <hidden> · 2021-11-23
Re: [PATCH 20/29] ext4: cleanup the dax handling in ext4_fill_super · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 20/29] ext4: cleanup the dax handling in ext4_fill_super · Christoph Hellwig <hch@lst.de> · 2021-11-24
[PATCH 24/29] xfs: use xfs_direct_write_iomap_ops for DAX zeroing · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 24/29] xfs: use xfs_direct_write_iomap_ops for DAX zeroing · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 24/29] xfs: use xfs_direct_write_iomap_ops for DAX zeroing · Dan Williams <hidden> · 2021-11-24
[PATCH 25/29] dax: return the partition offset from fs_dax_get_by_bdev · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 25/29] dax: return the partition offset from fs_dax_get_by_bdev · Dan Williams <hidden> · 2021-11-24
Re: [PATCH 25/29] dax: return the partition offset from fs_dax_get_by_bdev · Christoph Hellwig <hch@lst.de> · 2021-11-24
[PATCH 23/29] xfs: use IOMAP_DAX to check for DAX mappings · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 23/29] xfs: use IOMAP_DAX to check for DAX mappings · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 23/29] xfs: use IOMAP_DAX to check for DAX mappings · Christoph Hellwig <hch@lst.de> · 2021-11-24
Re: [PATCH 23/29] xfs: use IOMAP_DAX to check for DAX mappings · Dan Williams <hidden> · 2021-11-24
[PATCH 26/29] fsdax: shift partition offset handling into the file systems · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 26/29] fsdax: shift partition offset handling into the file systems · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 26/29] fsdax: shift partition offset handling into the file systems · Dan Williams <hidden> · 2021-11-24
Re: [PATCH 26/29] fsdax: shift partition offset handling into the file systems · Gao Xiang <hidden> · 2021-11-24
[PATCH 28/29] iomap: build the block based code conditionally · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 28/29] iomap: build the block based code conditionally · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 28/29] iomap: build the block based code conditionally · Dan Williams <hidden> · 2021-11-24
[PATCH 29/29] fsdax: don't require CONFIG_BLOCK · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 29/29] fsdax: don't require CONFIG_BLOCK · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 29/29] fsdax: don't require CONFIG_BLOCK · Dan Williams <hidden> · 2021-11-24
[PATCH 27/29] dax: fix up some of the block device related ifdefs · Christoph Hellwig <hch@lst.de> · 2021-11-09
Re: [PATCH 27/29] dax: fix up some of the block device related ifdefs · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-23
Re: [PATCH 27/29] dax: fix up some of the block device related ifdefs · Dan Williams <hidden> · 2021-11-24

From: Christoph Hellwig <hch@lst.de>
Date: 2021-11-24 06:39:40
Also in: dm-devel, linux-ext4, linux-fsdevel, linux-s390, linux-xfs, virtualization

On Tue, Nov 23, 2021 at 02:36:42PM -0800, Darrick J. Wong wrote:

quoted

-	phys_addr_t phys_off = (start_sect + sector) * 512;
-
-	if (pgoff)
-		*pgoff = PHYS_PFN(phys_off);
-	if (phys_off % PAGE_SIZE || size % PAGE_SIZE)

AFAICT, we're relying on fs_dax_get_by_bdev to have validated this
previously, which is why the error return stuff goes away?

Exactly.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help