Re: [PATCH v2 1/2] net: phy: motorcomm: add led_brightness_set for YT8521

From
Andrew Lunn <andrew@lunn.ch>
Date
2026-11-21 16:57:33
Also in
lkml
Reply to
Chukun Pan, 2026-11-20
On Fri, Nov 20, 2026 at 06:00:00PM +0800, Chukun Pan wrote:
Add support for manual brightness setting on YT8521/YT8531 PHY.
Testing with on/off and heartbeat on the Radxa E20C (YT8531).
Did you test enabling a mode which uses the hardware to blink?

Sometimes you need to take it out of forced mode. It could be that any
value other than 0 in YT8521_LED0_CFG_REG does that, but there is
nothing i can see here which suggests that.

If 0 is forced, maybe add

#define YT8521_LED_FORCED 0

next to YT8521_LED_10_ON_EN ?

Please also take a read of:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

You need to set the subject line.

    Andrew

---
pw-bot: cr
Thread (3 messages) 3 messages, 2 authors, last reply 4h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help