docs: networking: correct skb_shared_info field reference

Started by Sangmin Lee on Nov 20, 2026

Subsystems (3)

Maintainers (6)

Show 2 more
REVIEWED · 1 review, 1 by a maintainer

Status: Reviewed.

1 review trailer.

open the first message on its own page

Message details and related content
The skbuff documentation refers to skb_shared_info.refcount,
but struct skb_shared_info has no such member. The actual
field is skb_shared_info.dataref.

Correct the reference to match the structure definition. Use an inline
literal so the field name renders without a leading ampersand.

The discrepancy was identified with assistance from
GPT-6.2-Astra (xhigh) and manually verified against
include/linux/skbuff.h.

Codex built the affected page with Sphinx and verified the corrected
field name in the HTML output.

Fixes: ddccc9ef5599 ("skbuff: add a basic intro doc")
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Sangmin Lee <redacted>
---
Thank you, Willem.

I've always wanted to contribute to open source, but I was hesitant
to jump in. Your thoughtful review made me feel welcome and excited
to keep contributing.

Changes in v2:

- Use an inline literal for skb_shared_info.dataref so Sphinx renders
  the field name without the leading ampersand.

v1: https://lore.kernel.org/netdev/20261119164351.49040-1-45sangmin99@gmail.com/

 Documentation/networking/skbuff.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/networking/skbuff.rst b/Documentation/networking/skbuff.rst
index 94681523e..15a9a9399 100644
--- a/Documentation/networking/skbuff.rst
+++ b/Documentation/networking/skbuff.rst
@@ -21,7 +21,7 @@ to as shared skbs (see skb_shared()).
 
 skb_clone() allows for fast duplication of skbs. None of the data buffers
 get copied, but caller gets a new metadata struct (struct sk_buff).
-&skb_shared_info.refcount indicates the number of skbs pointing at the same
+``skb_shared_info.dataref`` indicates the number of skbs pointing at the same
 packet data (i.e. clones).
 
 dataref and headerless skbs
base-commit: 362917b0b26bd16587d41a37f5fd1c252099a73c
-- 
2.50.1 (Apple Git-155)
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help