Hi Matt,
thanks, all points taken. v6 is prepared but not sent: I will wait for
Netdev Sashiko to finish, as you asked.
- Threading: I see the same thing you do on lore. The patches are sent
with git send-email, which sets In-Reply-To to the Message-ID it assigned
to the cover letter, but our relay rewrites Message-ID on the way out
(the tencent_*... IDs on lore are not the ones the client wrote), so the
children end up pointing at an ID that never existed publicly. I have
not found a way to make that relay preserve the header; if you have a
suggestion that works with such a relay I would take it, otherwise I will
send the next version in a way that does not depend on the rewritten ID.
- Prefix: switched to "mptcp: " in v6.
- KUnit test: dropped. Beyond your point that a !token guard is not worth
50 lines, it also caused the build failure the test robot reported - the
case used mptcp_token_exists(), which is not exported, so
mptcp_token_test.ko failed at modpost when the test is built as a module.
The pre-existing token tests pass with the series: pass:4 fail:0.
- For backports I kept the code changes as three separate commits (ordering,
hash-membership check, token 0), so none of them carries test code.
- token 0: v6 says explicitly that no connection gets token 0 from this
implementation, and that the RFC 8684 token field does allow zero, so the
rejection is a Linux-side property, not a protocol one.
Two things I folded in from the Sashiko review of the same series, which
you may want to look at when you do the full review:
- [High] The acquire ordering does not cover the passive-open path, where
sk_clone() publishes the refcount before mptcp_sk_clone_init() sets the
token. v6 adds a separate patch that drops a socket which is no longer
on the chain after the increment, the way __inet_lookup_established()
does.
- [Low] The stable tag now names the dependency:
"Cc: stable@vger.kernel.org" plus a sentence pointing at
7f8ceea0c580 ("refcount: provide ops for cases when object's memory can
be reused") in the body.
Cheers,
Hang