On Sun, 15 Nov 2026 17:58:26 -0700 James Hilliard wrote:
stmmac_set_features() clears hw->rx_csum when RX checksum offload is
disabled, but sun8i_dwmac_rx_ipc_enable() unconditionally enables the
hardware checksum engine. The MAC therefore keeps dropping packets with
invalid IP or transport checksums before they reach the host, even after
ethtool reports RX checksumming as disabled.
Rx checksumming only controls whether the _good_ packet indication /
offload is communicated up the stack. The device should never drop
packets due to a bad L4 checksum. Checksumming L4 is not much of a DoS
vector. Oleksij was fixing this in other stmmac variants. I _think_ you
should always clear this bit if it leads to packet drops.
(FCS is fine, bad FCS should only be passed up if RX_ALL is set,
but sounds like your device has all checksums controlled by one bit?
in which case we prefer to see all and let driver discard the bad FCS)
If I completely misunderstand things we should at least get a respin
to update the cover letter. The commit message talks about L4 offload,
and rx_csum is L4 AFAIU but the bit is called CRC which deserves a
mention somewhere IMVHO.
--
pw-bot: cr