Re: [PATCH net v2 3/4] ptp: ocp: report disabled SMA inputs consistently over DPLL

From
Vadim Fedorenko <vadim.fedorenko@linux.dev>
Date
2026-11-19 22:24:07
Reply to
Ahmad Byagowi, 2026-11-19
On 19/11/2026 21:19, Ahmad Byagowi wrote:
quoted hunk ↗ jump to hunk
Disabling an SMA input clears its mux field. Zero is also the selector
for 10 MHz, so a DPLL read reports 10 MHz while sysfs reports None. The
DPLL core then treats a request to enable 10 MHz as unchanged and skips
the setter, leaving the input disabled.

Substitute SMA_DISABLE for disabled inputs before looking up the
frequency, as the sysfs path already does. The None entry reports zero
Hz and a subsequent 10 MHz request reaches the setter.

Reported by the netdev Sashiko AI review and confirmed by code
inspection. Source-derived C regression tests pass with ASan/UBSan;
restoring the faulty selector, mask, disabled-state or DCF value makes
the corresponding regression fail. Tests use stubbed MMIO, not hardware.
The driver object builds on current net with W=1 and KCFLAGS=-Werror. No
physical card was tested.

Codex prepared the fix, tests and changelog from the review and upstream
source, at the request to separate common-driver fixes from WiWi support
and validate removal ordering.

Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
Link: https://lore.kernel.org/r/179502617840.3136.12704245716223038161@kernel.org (local)
Signed-off-by: Ahmad Byagowi <redacted>
---
  drivers/ptp/ptp_ocp.c | 2 ++
  1 file changed, 2 insertions(+)
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
index f1f97c1fa0..06d05fac6e 100644
--- a/drivers/ptp/ptp_ocp.c
+++ b/drivers/ptp/ptp_ocp.c
@@ -5923,6 +5923,8 @@ static int ptp_ocp_dpll_frequency_get(const struct dpll_pin *pin,
  
  	val = bp->sma_op->get(bp, sma_nr + 1);
  	val &= SMA_SELECT_MASK;
+	if (sma->mode == SMA_MODE_IN && sma->disabled)
+		val = SMA_DISABLE;
  	tbl = bp->sma_op->tbl[sma->mode];
  	for (i = 0; tbl[i].name; i++)
  		if (val == tbl[i].value) {
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Thread (11 messages) 11 messages, 2 authors, last reply 1h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help