Re: [PATCH net v2] net: hsr: clean up synced addresses and allmulti in hsr_del_port()

From
patchwork-bot+netdevbpf@kernel.org
Date
2026-11-19 02:10:06
Also in
lkml
Reply to
Wenbo Sun, 2026-11-12
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Thu, 12 Nov 2026 14:47:16 +0800 you wrote:
hsr_set_rx_mode() syncs unicast and multicast addresses to slave A and
slave B devices via dev_uc_sync_multiple() and dev_mc_sync_multiple(),
and hsr_change_rx_flags() propagates IFF_ALLMULTI via
dev_set_allmulti().

When an UP HSR device is deleted via hsr_dellink(), hsr_del_ports()
removes all ports from hsr->ports before unregister_netdevice_queue()
leads to hsr_dev_close(). Consequently, hsr_dev_close() iterates over an
already-empty port list and cannot execute dev_uc_unsync() or
dev_mc_unsync() on the detached slaves. Likewise, when a slave device is
unregistered while the HSR master is UP, hsr_netdev_notify() calls
hsr_del_port() directly without running hsr_dev_close(). In addition,
hsr_dev_close() does not release IFF_ALLMULTI on slave devices either.
As a result, detached slave devices can retain synced unicast/multicast
addresses and an elevated allmulti reference count.

[...]
Here is the summary with links:
  - [net,v2] net: hsr: clean up synced addresses and allmulti in hsr_del_port()
    https://git.kernel.org/netdev/net-next/c/a02d05f6aff8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Thread (6 messages) 6 messages, 4 authors, last reply 14h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help