Re: [PATCH net-next v8 07/15] ibmveth: Add RX queue register helpers for MQ

From
mingming cao <hidden>
Date
2026-11-19 00:13:35
Also in
linuxppc-dev
Reply to
Jakub Kicinski, 2026-11-17
On 11/16/26 5:34 PM, Jakub Kicinski wrote:
On Mon,  9 Nov 2026 15:55:48 -0800 Mingming Cao wrote:
quoted
+	rc = ibmveth_alloc_buffer_pools(adapter);
+	if (rc) {
+		unsigned long ua = adapter->vdev->unit_address;
+		unsigned long lpar_rc;
  
-	if (lpar_rc != H_SUCCESS) {
-		netdev_err(netdev, "h_register_logical_lan failed with %ld\n",
-			   lpar_rc);
-		netdev_err(netdev, "buffer TCE:0x%llx filter TCE:0x%llx rxq "
-			   "desc:0x%llx MAC:0x%llx\n",
-				     adapter->buffer_list_dma[0],
-				     adapter->filter_list_dma,
-				     rxq_desc.desc,
-				     mac_address);
-		rc = -ENONET;
+		/* A kexec can leave the LAN registered by the old kernel
+		 * (see ibmveth_register_logical_lan()); do not leave its
+		 * buffers live in PHYP. H_PARAMETER if none is registered.
+		 */
+		do {
+			lpar_rc = h_free_logical_lan(ua);
+		} while (H_IS_LONG_BUSY(lpar_rc) || (lpar_rc == H_BUSY));
This loop is repeated in a number of places, you should probably factor
it out.

Done,  in the split prepare series.

Thanks,

Mingming
Thread (38 messages) 38 messages, 3 authors, last reply 8h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help