Re: [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-13 (ice)

From
Petr Oros <hidden>
Date
2026-11-18 13:52:06
Also in
intel-wired-lan
Reply to
Maciej Fijalkowski, 2026-11-18

On 11/18/26 2:48 PM, Maciej Fijalkowski wrote:
On Wed, Nov 18, 2026 at 02:37:06PM +0100, Magnus Karlsson wrote:
quoted
On Wed, 18 Nov 2026 at 13:00, Petr Oros [off-list ref] wrote:
quoted
I think this pull is a good moment to ask how fixes for Intel drivers
should flow, because it is not the first time a fix spent months on
intel-wired-lan and then hit a wall on net.

My patches 2/6 and 3/6 have been on intel-wired-lan since June, v4 on
July 8 [1]. They were reviewed and tested by Intel validation there,
and four months later Sashiko found real problems in them on this
pull. I have a v5 and will send it once it is tested.

Jake's E82x timestamp fixes went through three pulls before a part of
them was applied [2], and Maciej described the same loop on the i40e
pull in September [3].

I know Intel patches go through iwl and are not applied to net
directly [4]. But for fixes it means that the review which decides
happens on netdev months after the iwl review and validation, and every
respin goes through both again. And if iwl stops cross-posting to
netdev, as Jakub suggested [5], Sashiko will see Intel fixes only in
the pull.

So does the iwl round still make sense for fixes? Would it be better to
send fixes straight to net with iwl in Cc, and have Tony's ack and the
Tested-by from Intel validation on netdev?
Glad you brought this up. IMO, it makes no sense for fixes to go
through iwl and it makes contributing fixes (or new
features/optimizations) a lot more painful. Sometimes even to the
point that you just stop contributing something. I am not in the NIC
team at Intel, but sometimes I have to do network core work that also
touches our drivers. In this case, that patch set goes straight to
net-next (as iwl cannot and should not take core patches), but any
driver fix that I find on the way needs to go to iwl-net so that it
can go to net and be backported. So the fixes that my patch set are
dependent on and that should go in first are instead sent to a
slow-path (i.e. iwl-net) and after X weeks/months appear in net and
then net-next. But my patch set in net-next is dependent on these
fixes so I have to either wait or just cross my fingers that my new
feature is stable enough even without those fixes. Not optimal in my
opinion.

So anything that could be done to speed up this process would be very
welcome. Sending fixes straight to net would be great. The validation
team could pick those patches up from the list and run the regression
tests against them, or would that take too long?
Regarding providing Tested-by tags, could we lift the policy where only
Intel validation is allowed to bless the patch? Nowadays with AI regular
dev can spin up a nice pile of tests by themselves.

So if you send a fix and you can find a peer that will test and review it
for you, I don't think we have to wait for validation folks taking care of
it if they are swamped.

I also don't think it would backfire on us and we would introduce some
bloody regressions, given we have {s,cl}ashikos in the pipeline.
BIG +1
quoted
Anyway, good initiative. I am sure there is a solution to this that we
will all like.

/Magnus
quoted
[1] https://lore.kernel.org/all/20260708125755.706263-1-poros@redhat.com/ (local)
[2] https://lore.kernel.org/all/20261021-jk-e825c-timestamp-processing-logic-fixes-srcu-v5-0-72289a4ac8eb@intel.com/ (local)
[3] https://lore.kernel.org/all/are4rBUJO3mzrkO8@boxer/ (local)
[4] https://lore.kernel.org/all/20260721174642.7749143e@kernel.org/ (local)
[5] https://lore.kernel.org/all/20260922112216.41e6f8cf@kernel.org/ (local)

Regards,
Petr
  
Thread (17 messages) 17 messages, 6 authors, last reply 4h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help