Re: [PATCH net v4 06/14] net: pse-pd: check the PI state under the lock when setting a power limit

From
Kory Maincent <kory.maincent@bootlin.com>
Date
2026-11-18 10:08:09
Also in
lkml
Reply to
Carlo Szelinsky, 2026-11-16

On 11/16/26 19:20, Carlo Szelinsky wrote:
On Sun, 15 Nov 2026 21:00:55 +0000, netdev-bot+sashiko@kernel.org wrote:
quoted
Does this description understate what the old race did? It looks like
the budget was leaked permanently, not just reserved for a while.
Right, the budget is lost until the controller is bound again.
v5 says that, and fixes the old "powered" comment.
quoted
Is admin_state_enabled && isr_pd_detected enough to show that the port is
actually powered?
quoted
Does this still leave part of the race with pse_isr() open?
Both were there before this patch, which only moves the old check
under the lock. They need their own fixes, so I keep them out of
this series. The cover letter lists both.

Kory, are you OK with fixing the two older problems in a follow-up?
I am happy to work on them next, if you have a preferred approach.
Yes, I am ok with this.
Also, are you fine with the rest of v4? I kept your Reviewed-by on 8
after the small change there, so please tell me if that is not OK.
Except for comment change or commit message change, I would prefer to have my R-by removed if there is code change. Thanks for asking.

For patch 8, I am ok with the changes, you can keep my R-by.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
Thread (18 messages) 18 messages, 3 authors, last reply 7h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help