Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 1 · Low: 1
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] In oa_tc6_prcs_rx_chunk_payload()
(drivers/net/ethernet/oa_tc6/oa_tc6_main.c), frames the MAC-PHY marks…
- [Low] This concern is retained only because it requires validation.
--
net: ethernet: oa_tc6: Drop frames if footer has FD bit set
This patch adds handling for the Frame Drop (FD) bit in the receive data
chunk footer in oa_tc6_prcs_rx_chunk_payload(). When the last chunk of a
frame has FD set, any partially assembled rx_skb is freed and the dropped
frame's data is skipped. If the same chunk also carries the start of a
new frame, that new frame is still processed.
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/oa_tc6/oa_tc6_main.c b/drivers/net/ethernet/oa_tc6/oa_tc6_main.c
index 2b31370da2d2b..5d01ef5a13ad0 100644
--- a/drivers/net/ethernet/oa_tc6/oa_tc6_main.c
+++ b/drivers/net/ethernet/oa_tc6/oa_tc6_main.c
[ ... ]
quoted hunk ↗ jump to hunk
@@ -1159,6 +1160,25 @@ static int oa_tc6_prcs_rx_chunk_payload(struct oa_tc6 *tc6, u8 *data,
if (tc6->wait_until_start_valid)
return 0;
+ /* Drop the frame, if footer sets FD bit. Checking FD bit
+ * becomes important, when cut-through operation is enabled.
+ */
[Severity: Low]
The only scenario the commit message gives for FD being set is RX
cut-through:
With RX cut-through enabled, the MAC-PHY can start forwarding a frame
before it knows the frame is bad, and uses FD to tell the host to
discard it.
At this commit nothing enables cut-through. struct oa_tc6 has no
cut-through state yet, and nothing writes OA_TC6_CONFIG0_RXCTE.
The later S2500 patch in this series adds ctc_capable,
oa_tc6_rx_cut_through_enable() and the OA_TC6_CONFIG_RX_CUT_THROUGH
quirk. That makes this patch groundwork for that change, and the ordering
looks fine.
Can the existing MAC-PHYs (LAN865x and others) also set FD in their
default store-and-forward mode? If so, frames marked FD would currently
reach the stack through oa_tc6_submit_rx_skb()->netif_rx(). Should this
then carry a Fixes: tag? If not, could the commit message say that
cut-through is enabled by a later patch in the series?
quoted hunk ↗ jump to hunk
+ if (end_valid && frame_drop) {
+ oa_tc6_cleanup_ongoing_rx_skb(tc6);
+
+ /* Full frame in this chunk. Nothing to free. Move on to
+ * next chunk.
+ */
+ if (start_valid && start_byte_offset < end_byte_offset) {
+ tc6->netdev->stats.rx_dropped++;
+ return 0;
+ }
[Severity: Medium]
Should frames with FD set be counted in rx_errors rather than only in
rx_dropped?
For a frame that fits in one chunk, this block increments only
rx_dropped. For a frame that spans several chunks, the
oa_tc6_cleanup_ongoing_rx_skb() call above also increments only
rx_dropped:
static void oa_tc6_cleanup_ongoing_rx_skb(struct oa_tc6 *tc6)
{
if (tc6->rx_skb) {
tc6->netdev->stats.rx_dropped++;
kfree_skb(tc6->rx_skb);
tc6->rx_skb = NULL;
}
}
The kernel-doc for struct rtnl_link_stats64 in
include/uapi/linux/if_link.h defines these counters as follows:
@rx_errors: Total number of bad packets received on this network device.
@rx_dropped: Number of packets received but not processed,
e.g. due to lack of resources or unsupported protocol.
The commit message describes FD frames as frames the MAC-PHY "knows the
frame is bad". These are bad frames from the wire, not host-side drops.
With cut-through enabled on S2500 later in the series, would every
corrupted frame on the segment show up as rx_dropped in ip -s link while
rx_errors stays at 0?
quoted hunk ↗ jump to hunk
+
+ /* The chunk carries only the end of the dropped frame. */
+ if (!start_valid)
+ return 0;
+ }
+
[ ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113-s2500-mac-phy-support-v11-0-7a186141952c%40onsemi.com