T Theodor Arsenij Larionov Trichkine #
Message details and related content
A pskb copy keeps the mac_header offset but not the headroom, so a copy of a received packet has its mac header in uninitialised bytes, which nft dup can return to userspace. Patch 2 unsets the mac header of such a copy, as Florian suggested on v1. Patch 1 makes the nfnetlink_queue bridge adjustment check the mac header first; without it, patch 2 turns a queued GSO copy of a bridged packet into an out-of-bounds push. v2: fix in __pskb_copy_fclone() instead of nf_dup; add patch 1. v1: https://lore.kernel.org/netfilter-devel/20261116105113.128791-1-theodorlarionov@gmail.com/ Theodor Arsenij Larionov Trichkine (2): netfilter: nfnetlink_queue: only adjust bridged skbs that have a mac header net: unset the mac header of a pskb copy that points into headroom net/core/skbuff.c | 2 ++ net/netfilter/nfnetlink_queue.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) -- 2.34.1