On Tue, Nov 17, 2026 at 09:49:18AM -0800, Joe Damato wrote:
On Tue, Nov 17, 2026 at 07:51:06PM +0300, Dmitry Antipov wrote:
quoted
In store_backup_port(), prefer strchrnul() over strchr() to
avoid redundant call to strlen().
a couple things:
- i dont't think the change is worth it because it feels like unnecessary
churn in a path that isn't a hot path. how many bytes are we really avoiding
counting here?
- commit message mentions store_backup_port but subject line says
show_backup_port, so commit would need to be respun
but imho i think this should be dropped
Yep.
pw-bot: rejected