On Thu, Nov 19, 2026 at 12:40 PM [off-list ref] wrote:
Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 1 · Low: 1 (1)
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] After this patch, stmmac_hw_setup()
(drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3725-3729) checks…
- [Low] The struct stmmac_ops comment for rx_ipc
(drivers/net/ethernet/stmicro/stmmac/hwif.h:322) still says "Enable…
Pre-existing issues:
- [Low] This problem wasn't introduced by this patch, but
sun8i_dwmac_rx_ipc_enable()…
--
net: stmmac: preserve RX checksum capability when offload is disabled
This patch changes stmmac_hw_setup() so that a zero return from
stmmac_rx_ipc() clears plat->rx_coe only when RX checksum offload was
requested, meaning hw->rx_csum is non-zero. Before this, the RX COE
capability was lost when the interface was reopened after RX checksum
offload had been turned off with ethtool.
quoted
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 25894771e9e9f..e162976be2e6d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -3723,7 +3723,7 @@ static int stmmac_hw_setup(struct net_device *dev)
stmmac_safety_feat_configuration(priv);
ret = stmmac_rx_ipc(priv, priv->hw);
- if (!ret) {
5 more quoted lines
Yes. On GMAC, GMAC4 and XGMAC, zero is the expected readback when
offload is disabled. Clearing plat->rx_coe on that basis is what makes
a working feature disappear after the interface is reopened.
What v2 misses is the later live enable. stmmac_set_features() sets
hw->rx_csum from plat->rx_coe and ignores the readback. If the enable
bit stays clear, the RX path can mark an unchecked packet as
CHECKSUM_UNNECESSARY. I haven't seen the bit fail to latch on hardware,
but the driver should check it when enabling offload and leave software
checksum reporting off if the enable fails. The rx_ipc comment should
also say that these callbacks return whether the checker is enabled,
not whether the hardware supports it.
For example, if "ethtool -K ethX rx off" runs before the first
"ip link set up", the readback is never checked. plat->rx_coe then keeps
whatever value the HW feature register or platform data reported.
If RX checksum is later enabled while the interface is up,
stmmac_fix_features() keeps NETIF_F_RXCSUM because rx_coe is not
STMMAC_RX_COE_NONE. stmmac_set_features() then ignores the rx_ipc result:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:stmmac_set_features() {
if (features & NETIF_F_RXCSUM)
priv->hw->rx_csum = priv->plat->rx_coe;
else
priv->hw->rx_csum = 0;
/* No check needed because rx_coe has been set before and it will be
* fixed in case of issue.
*/
stmmac_rx_ipc(priv, priv->hw);
...
}
That comment assumes the stmmac_hw_setup() check has already run, and
after this patch that is not guaranteed. Before this patch, any open
with a zero readback cleared rx_coe. So once the interface had been
opened, offload could not be enabled at runtime without a check.
Some hardware may advertise RX COE while its IPC bit does not latch. On
such hardware, hw->rx_csum would be non-zero while the MAC is not
validating checksums. stmmac_rx() and stmmac_construct_skb_zc() would
then mark IP frames CHECKSUM_UNNECESSARY based on hw->rx_csum:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:stmmac_construct_skb_zc() {
...
if (unlikely(!coe) || !stmmac_has_ip_ethertype(skb))
skb_checksum_none_assert(skb);
else
skb->ip_summed = CHECKSUM_UNNECESSARY;
...
}
46 more quoted lines
That's correct. The sun8i callback always returns 1, so it doesn't
trigger the capability loss fixed here. The separate sun8i patch [0]
keeps the hardware checker enabled in both modes and lets packets
whose only error is a bad IP or transport checksum reach the stack as
CHECKSUM_NONE. On that MAC, ethtool rx off controls whether the driver
reports a checksum as verified, not whether the MAC checks it.
[0] https://lore.kernel.org/r/20261120-submit-sun8i-rx-features-v1-v1-1-5058fecba6b3@gmail.com/
pw-bot: cr
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c:sun8i_dwmac_rx_ipc_enable() {
...
v = readl(ioaddr + EMAC_RX_CTL0);
v |= EMAC_RX_DO_CRC;
writel(v, ioaddr + EMAC_RX_CTL0);
return 1;
}
So on sun8i, "ethtool -K ethX rx off" leaves the EMAC checksum engine
on.
stmmac_rx() still treats these frames as CHECKSUM_NONE because coe is
0, so I could not find any frames being marked with the wrong checksum
state. The problem is that the register state does not match the
requested state.
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261117-submit-stmmac-rx-checksum-capability-v1-v2-1-059f9499c386%40gmail.com