Re: [PATCH net 2/2] selftests/net: check that a short SO_PEERPIDFD optlen fails

From
Alexander Mikhalitsyn <hidden>
Date
2026-11-17 16:39:45
Also in
linux-fsdevel
Reply to
Christian Brauner, 2026-11-17
On Tue, 2026-11-17 at 16:25 +0100, Christian Brauner wrote:
Cover SO_PEERPIDFD and SO_PEERPIDFD_THREAD with an optlen of 0 to 3:

- getsockopt() fails with EINVAL
- optlen and the buffer stay untouched
- no pidfd is installed in the file descriptor table

Check that a full-sized buffer still gets a pidfd.
Reviewed-by: Alexander Mikhalitsyn <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
---
 tools/testing/selftests/net/af_unix/scm_pidfd.c | 51
+++++++++++++++++++++++++
 1 file changed, 51 insertions(+)
diff --git a/tools/testing/selftests/net/af_unix/scm_pidfd.c
b/tools/testing/selftests/net/af_unix/scm_pidfd.c
index cbe53fab44fc5..c26f055a19032 100644
--- a/tools/testing/selftests/net/af_unix/scm_pidfd.c
+++ b/tools/testing/selftests/net/af_unix/scm_pidfd.c
@@ -1155,4 +1155,55 @@ TEST(so_peerpidfd_thread)
 	close(server);
 }
 
+/* The lowest free file descriptor, where the next pidfd would land.
*/
+static int lowest_free_fd(int fd)
+{
+	int nfd;
+
+	nfd = dup(fd);
+	if (nfd >= 0)
+		close(nfd);
+	return nfd;
+}
+
+/* A short optlen must fail without installing a pidfd. */
+TEST(so_peerpidfd_short_optlen)
+{
+	const int optnames[] = { SO_PEERPIDFD, SO_PEERPIDFD_THREAD
};
+	int sv[2], i, free_fd, pidfd;
+	socklen_t len, optlen;
+
+	ASSERT_EQ(0, socketpair(AF_UNIX, SOCK_STREAM, 0, sv));
+
+	for (i = 0; i < ARRAY_SIZE(optnames); i++) {
+		for (len = 0; len < sizeof(pidfd); len++) {
+			free_fd = lowest_free_fd(sv[0]);
+			ASSERT_LE(0, free_fd);
+
+			pidfd = -1;
+			optlen = len;
+			ASSERT_EQ(-1, getsockopt(sv[0], SOL_SOCKET,
optnames[i],
+						 &pidfd, &optlen));
+			ASSERT_EQ(EINVAL, errno);
+			EXPECT_EQ(len, optlen);
+			EXPECT_EQ(-1, pidfd);
+
+			/* No pidfd was installed behind our back.
*/
+			ASSERT_EQ(free_fd, lowest_free_fd(sv[0]));
+		}
+
+		/* A full-sized buffer still gets the pidfd. */
+		free_fd = lowest_free_fd(sv[0]);
+		optlen = sizeof(pidfd);
+		ASSERT_EQ(0, getsockopt(sv[0], SOL_SOCKET,
optnames[i],
+					&pidfd, &optlen));
+		EXPECT_EQ(sizeof(pidfd), optlen);
+		EXPECT_EQ(free_fd, pidfd);
+		close(pidfd);
+	}
+
+	close(sv[0]);
+	close(sv[1]);
+}
+
 TEST_HARNESS_MAIN
Thread (5 messages) 5 messages, 2 authors, last reply 5h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help