Re: [PATCH net-next v4 1/2] net: phy: move DECLARE_PHY_INTERFACE_MASK_ZERO to core

From
Andrew Lunn <andrew@lunn.ch>
Date
2026-11-17 14:04:30
Also in
linux-arm-kernel, linux-rockchip, lkml
Reply to
Coia Prant, 2026-11-17
I understand your concern that hiding the init inside the macro seems
subjective. Since you mentioned an Andrew ack is needed, and he is the
net PHY maintainer (who also looks after the WX driver),
I don't look after the WX driver. I comment on it, as i comment on
lots of drivers.
If Andrew also feels this doesn't belong in the core, I will drop the
macro entirely and switch to explicit manual initialization using
phy_interface_zero() in both drivers.
Using phy_interface_zero() is what current code does. I would also say
using explicate = {0, } is O.K, but i would not hide it in the macro.

      Andrew
Thread (7 messages) 7 messages, 4 authors, last reply 2h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help