Re: [PATCH net-next v2] net: ethernet: mtk-star-emac: fix device_node leak in mtk_star_probe()

From
patchwork-bot+netdevbpf@kernel.org
Date
2026-11-17 00:00:13
Also in
linux-arm-kernel, linux-mediatek, lkml
Reply to
Xia Yan, 2026-11-12
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Thu, 12 Nov 2026 11:51:30 +0800 you wrote:
mtk_star_probe() gets the PHY node from the "phy-handle" property
with of_parse_phandle(). The helper takes a reference on the node it
returns. The node is used by of_phy_connect() each time the netdevice
is opened.

That reference is never dropped. Every error return after the lookup
leaks it. Unbind leaks it as well: the driver is devm-only and has no
remove callback.

[...]
Here is the summary with links:
  - [net-next,v2] net: ethernet: mtk-star-emac: fix device_node leak in mtk_star_probe()
    https://git.kernel.org/netdev/net-next/c/b78cbbb527ad

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Thread (6 messages) 6 messages, 5 authors, last reply 2d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help