Re: [PATCH net] net: qed: fix dead NULL check on the MPA buffer list

From
Ziheng Wei <hidden>
Date
2026-11-16 16:32:07
Also in
lkml, stable
Reply to
netdev-bot+sashiko@kernel.org, 2026-11-16
On Mon, 16 Nov 2026 16:21:12 +0000, netdev-bot+sashiko@kernel.org wrote:
rx_num_desc sizes both pools. Doesn't that make the "No free mpa buf"
path unreachable, whatever the traffic or the value of rx_num_desc?
Yes, I agree. Every mpa_buf held on the pending list still owns an RX
buffer that has not been reposted, so a new completion can never find
mpa_buf_list empty. The "depends on traffic" sentence in the changelog
is wrong, and the only evidence was a test module that empties the
list by hand.
If that path ever ran, it would repost the RX buffer and drop a TCP
segment that firmware already sent to the unaligned MPA path.
Agreed as well, so making the error path reachable is not even an
obviously better behaviour than the current code.
Is this an accurate description of fbb8bc408027?
No, it only touched qed_ooo.c. Sorry for the inaccurate description.

Please drop this patch. The Fixes: and stable tags do not fit, and I
don't think a hardening-only respin is worth it for an unreachable
path.

pw-bot: cr
Thread (3 messages) 3 messages, 2 authors, last reply 2d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help