Re: [PATCH net-next v3 2/2] net: stmmac: dwmac-rk: Add RK3572 support

From
Cunhao Lu <hidden>
Date
2026-11-16 15:11:48
Also in
linux-arm-kernel, linux-devicetree, linux-rockchip, lkml
Reply to
Andrew Lunn, 2026-11-16
Hi,
[...]
quoted
+ .regs_valid = true,
+ .regs = { 0x29d20000, 0x2a040000, 0 },
+};
Just looking at this, it is not obvious that rx_delay and tx_delay are
actually not used.
My board currently uses rgmii-id, where both MAC TX and RX delays
are disabled. I kept the delay handling to support rgmii-rxid,
rgmii-txid and rgmii, using the default values for the MAC delays
enabled in those modes. The legacy tx_delay and rx_delay properties
are now disallowed for RK3572 in the binding.

I currently have only one oscilloscope, with a maximum bandwidth of
200 MHz. With this equipment, I cannot accurately determine how the
TX and RX delay register values translate to picoseconds, so I am
not planning to add support for tx-internal-delay-ps and
rx-internal-delay-ps in this series for now.

Would it be acceptable to support only rgmii-id for RGMII in the next
version, and reject rgmii, rgmii-rxid and rgmii-txid? This would let me
stop using tx_delay and rx_delay in the RK3572 driver path as well.

Best regards,
Cunhao Lu
Thread (10 messages) 10 messages, 4 authors, last reply 7h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help