Re: [PATCH net v3 2/2] selftests: net: veth: propagate bad-settings check failures to exit status

From
Tianyi Gao <hidden>
Date
2026-11-16 14:05:03
Also in
bpf, linux-kselftest, lkml
Reply to
Omokefe Emmanuel Onanaroghene, 2026-11-16
On Mon, 16 Nov 2026 09:41:07 +0100 Omokefe Emmanuel Onanaroghene wrote:
-             echo "fail - set operation successful ?!?" || echo " ok "
+             { echo "fail - set operation successful ?!?"; ret=1; } || echo " ok "
Two small suggestions:

1. These lines are 85 columns wide, over the 80-column limit.
2. The style is inconsistent with the rest of the file. Other checks
   use if/else instead of a "cmd && { ...; } || ..." chain.

Cheers,
Tianyi
Thread (9 messages) 9 messages, 4 authors, last reply 21h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help