Re: [PATCH net v4 0/2] net: openvswitch: fix a feature leak on a failed change

From
Minxi Hou <hidden>
Date
2026-11-16 12:32:36
Also in
linux-kselftest
Reply to
Matthieu Baerts, 2026-11-16
Hi Matt,

You are right about the hang, and it is mine. I reproduced it here.

To get a failure reason into the CI log I duplicated stdout onto fd 9 in
openvswitch.sh, because info() writes debug.log and a failing run
deletes that file. The suite starts daemons that outlive the script: the
per-vport upcall handlers from add-if -u, and the psample listener. They
inherit the second handle. runner.sh reads the test output from a pipe,
so as long as any process holds the write end, the pipe never reaches
EOF and the run sits there after the last subtest has already passed.

Redirecting the output to a file hides this completely, which is how I
ran it, and why I did not see it.

Writing those messages to stderr fixes it. stderr still reaches the
runner from inside ovs_sbx, and the daemons send both stdout and stderr
to files, so nothing is left holding the pipe.

Checked with the output piped the way runner.sh does it:

  before: "TEST: psample ... [ OK ]", then nothing until the timeout
  after:  21 tests [ OK ], and the run ends by itself
  with a wrong expectation injected: the reason still reaches the log and
  the test fails, so the diagnostics still work

The configs merge here as well. The only message is the CONFIG_IP_SCTP
m->y redefine, which is already in the fragment before this series.

I will send a v5 with this change.

Thanks,
Minxi
Thread (9 messages) 9 messages, 4 authors, last reply 23h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help