Re: [PATCH net v2 0/2] tcp/mptcp: prevent blackhole timeout arithmetic wraparound

From
Matthieu Baerts <matttbe@kernel.org>
Date
2026-11-16 12:29:25
Also in
linux-doc, lkml, mptcp
Reply to
Eric Dumazet, 2026-11-15
Hi Eric, Yingjie,

On 15/11/2026 09:24, Eric Dumazet wrote:
Le sam. 14 nov. 2026 à 17:12, Yingjie Wang [off-list ref] a écrit :
quoted
The TCP Fast Open and MPTCP blackhole handlers multiply writable timeout
sysctl values before adding the result to a jiffies timestamp. The
multiplication is performed in 32-bit unsigned arithmetic, so a large
value can wrap into a short delay even on a 64-bit kernel.

With HZ=1000, a timeout of 6912213 seconds and the maximum multiplier of
64 should produce 442,381,632,000 jiffies, but the current calculations
truncate the result to 512 jiffies. Both patches compute the delay in u64
and cap it at MAX_JIFFY_OFFSET before adding it to the saved timestamp.

The issues were found using a static analysis tool. In the v1 arithmetic
A/B tests, loopback reproducers induced 12 blackholes, waited 1.2 seconds,
and then made a new connection:

  TFO:   base probe 1.026 s, TCPFastOpenActiveFail +1;
         fixed probe 0.000 s, TCPFastOpenActiveFail +0.
  MPTCP: base probe 3.087 s, MPCapableSYNTXDisabled +0;
         fixed probe 0.000 s, MPCapableSYNTXDisabled +1.

The TFO counter records another failed active Fast Open attempt. The
MPTCP counter records a connection that skips MP_CAPABLE and falls back to
TCP while active MPTCP is disabled.

Changes since v1:

- Add a reasonable upper bound for the TCP Fast Open sysctl, as requested
  by Kuniyuki Iwashima. This version proposes one day (86400 seconds),
  using the existing IPv4 one_day_secs bound, and documents that limit.
  Keep the existing MPTCP sysctl input range.
The one day limit, the u64 computation and the clamp look fine to me
for the TCP side: with HZ=1000, 64 * 86400 * HZ still does not fit in
32 bits, and 32-bit kernels need the interval to stay below 2^31 jiffies
for time_before().

Why is MPTCP left alone? Kuniyuki's remark applies equally to
net.mptcp.blackhole_timeout: nobody needs a multi-day initial timeout
there either. I will let MPTCP maintainers decide, but having the two
sysctls behave differently looks odd.
I agree with Eric: these two "blackhole" sysctl knobs are similar, and
the behaviour shouldn't differentiate then.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Thread (7 messages) 7 messages, 4 authors, last reply 1d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help