Re: [PATCH 07/11] eth: ixgbe: use dma_alloc_coherent_node()

From
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Date
2026-11-16 12:22:11
Also in
linux-iommu
Reply to
Jakub Kicinski, 2026-11-06
On 11/6/26 19:44, Jakub Kicinski wrote:
Use dma_alloc_coherent_node() to place the descriptor rings on the
node of the ring's q_vector, instead of temporarily changing the node
of the device. NUMA_NO_NODE (ring without a q_vector) means no
preference, same as what set_dev_node(dev, NUMA_NO_NODE) resulted in.

Reviewed-by: Björn Töpel <bjorn@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
nice!
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
quoted hunk ↗ jump to hunk
---
v1: no change
rfc: https://lore.kernel.org/20261027022528.633359-8-kuba@kernel.org (local)
---
  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 20 ++++++-------------
  1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index b9496f0bee13..6458cb2e511e 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -7083,7 +7083,6 @@ static int ixgbe_sw_init(struct ixgbe_adapter *adapter,
  int ixgbe_setup_tx_resources(struct ixgbe_ring *tx_ring)
  {
  	struct device *dev = tx_ring->dev;
-	int orig_node = dev_to_node(dev);
  	int ring_node = NUMA_NO_NODE;
  	int size;
  
@@ -7102,12 +7101,9 @@ int ixgbe_setup_tx_resources(struct ixgbe_ring *tx_ring)
  	tx_ring->size = tx_ring->count * sizeof(union ixgbe_adv_tx_desc);
  	tx_ring->size = ALIGN(tx_ring->size, 4096);
  
-	set_dev_node(dev, ring_node);
-	tx_ring->desc = dma_alloc_coherent(dev,
-					   tx_ring->size,
-					   &tx_ring->dma,
-					   GFP_KERNEL);
-	set_dev_node(dev, orig_node);
+	tx_ring->desc = dma_alloc_coherent_node(dev, tx_ring->size,
+						&tx_ring->dma, GFP_KERNEL,
+						ring_node);
  	if (!tx_ring->desc)
  		tx_ring->desc = dma_alloc_coherent(dev, tx_ring->size,
  						   &tx_ring->dma, GFP_KERNEL);
@@ -7184,7 +7180,6 @@ int ixgbe_setup_rx_resources(struct ixgbe_adapter *adapter,
  			     struct ixgbe_ring *rx_ring)
  {
  	struct device *dev = rx_ring->dev;
-	int orig_node = dev_to_node(dev);
  	int ring_node = NUMA_NO_NODE;
  	int size;
  
@@ -7203,12 +7198,9 @@ int ixgbe_setup_rx_resources(struct ixgbe_adapter *adapter,
  	rx_ring->size = rx_ring->count * sizeof(union ixgbe_adv_rx_desc);
  	rx_ring->size = ALIGN(rx_ring->size, 4096);
  
-	set_dev_node(dev, ring_node);
-	rx_ring->desc = dma_alloc_coherent(dev,
-					   rx_ring->size,
-					   &rx_ring->dma,
-					   GFP_KERNEL);
-	set_dev_node(dev, orig_node);
+	rx_ring->desc = dma_alloc_coherent_node(dev, rx_ring->size,
+						&rx_ring->dma, GFP_KERNEL,
+						ring_node);
  	if (!rx_ring->desc)
  		rx_ring->desc = dma_alloc_coherent(dev, rx_ring->size,
  						   &rx_ring->dma, GFP_KERNEL);
  
Thread (27 messages) 27 messages, 6 authors, last reply 1d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help