Re: [PATCH net-next v5 2/3] ethtool: add a PHY receive byte total

From
Andrew Lunn <andrew@lunn.ch>
Date
2026-11-16 04:40:11
Also in
linux-doc, lkml
Reply to
James Hilliard, 2026-11-16
On Sun, Nov 15, 2026 at 09:12:35PM -0700, James Hilliard wrote:
On Sun, Nov 15, 2026 at 8:25 AM Andrew Lunn [off-list ref] wrote:
quoted
On Sun, Nov 15, 2026 at 12:45:46AM -0700, James Hilliard wrote:
quoted
The generic PHY receive-byte counter describes successfully received
traffic. Some PHYs instead count bytes in all received frames,
including frames with errors.
That restriction comes from the current kernel-doc definition of
ethtool_phy_stats.rx_bytes: "Total successfully received bytes".
Yes, i found this.
Should we instead clarify the existing rx_bytes definition to include
errored traffic and use it for ACx00, dropping rx_bytes_total? That
would leave the existing packet counters unchanged.
What do you mean by errored traffic?

Think about it.

If you don't have a MAC, you don't have FCS.

	Andrew
Thread (15 messages) 15 messages, 4 authors, last reply 1h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help