[PATCH net-next v3] net: stmmac: dwmac-sun8i: Fix use-after-free in the MDIO mux error path

From
Arun Iyengar via B4 Relay <devnull+aiyengar1990.gmail.com@kernel.org>
Date
2026-11-15 09:05:08
Also in
b4-sent, linux-arm-kernel, linux-sunxi, lkml
From: Arun Iyengar <redacted>

If mdio_mux_init() fails after the internal PHY was powered, the error
path releases rst_ephy and ephy_clk before sun8i_dwmac_exit() uses them
to unpower it. Unpower the PHY first, as sun8i_dwmac_remove() does.

Signed-off-by: Arun Iyengar <redacted>
---
Found by Sashiko's review of another dwmac-sun8i series of mine.
Build-tested only (arm64 and arm, W=1): I have no board with the
internal PHY (H3, H5 or V3s), so the error path was not exercised.

Developed with Claude (Anthropic); I reviewed it.
---
Changes in v3:
- Drop the Fixes tag (Andrew Lunn)
- Shorter commit message
- Link to v2: https://patch.msgid.link/20261113-sun8i-emac-mux-uaf-v2-1-6203666b2687@gmail.com (local)

Changes in v2:
- Target net-next instead of net, drop Cc: stable (Andrew Lunn)
- Shorter commit message
- Rebased onto net-next
- Link to v1: https://patch.msgid.link/20261112-sun8i-emac-mux-uaf-v1-1-308ae7e6fcf2@gmail.com (local)
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
index 2ece7ba9dd73..898560e8e95c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
@@ -1245,6 +1245,7 @@ static int sun8i_dwmac_probe(struct platform_device *pdev)
 	return 0;
 
 dwmac_mux:
+	sun8i_dwmac_unpower_internal_phy(gmac);
 	reset_control_put(gmac->rst_ephy);
 	clk_put(gmac->ephy_clk);
 dwmac_remove:
---
base-commit: 6964ff21c5d8b75649211a52dbfd92753e605649
change-id: 20261112-sun8i-emac-mux-uaf-1ba885219fee

Best regards,
--  
Arun Iyengar [off-list ref]

Thread (2 messages) 2 messages, 2 authors, last reply 9h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help