Re: [PATCH net-next 08/14] rds: annotate data-races around core rds sysctls

From
Simon Horman <horms@kernel.org>
Date
2026-11-13 17:15:39
Also in
bridge, linux-rdma, linux-s390, linux-sctp, linux-security-module, lkml, lvs-devel, mptcp, netfilter-devel
Reply to
Jiayuan Chen, 2026-11-09
On Mon, Nov 09, 2026 at 10:52:07AM +0800, Jiayuan Chen wrote:
reconnect_min_delay_ms, reconnect_max_delay_ms, max_unacked_packets,
max_unacked_bytes and ping_enable are read without any lock while their
sysctl handlers update them with WRITE_ONCE(). Add READ_ONCE() to the
readers.

Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
As per my remarks on another patch. Networking does prefer lines
80 columns wide or less. But I am inclined to turn a blind eye
to the in the case of longer lines introduced by this patch because
they are not that much longer and addressing them seems rather tedious.
That said, I would not object to them being fixed.

Reviewed-by: Simon Horman <horms@kernel.org>

...
Thread (37 messages) 37 messages, 6 authors, last reply 2d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help