Re: [PATCH net-next 1/2] bonding: 3ad: Receive packets in COLLECTING state

From
Nikolay Aleksandrov <razor@blackwall.org>
Date
2026-11-13 09:35:03
Reply to
Ido Schimmel, 2026-11-11
On 11/11/2026 19:19, Ido Schimmel wrote:
quoted hunk ↗ jump to hunk
When coupled control is disabled, a port in COLLECTING state is supposed
to receive packets, but it does not. The bond only delivers packets from
slaves whose 'inactive' flag is cleared, whereas
bond_set_slave_rx_enabled_flags() only clears 'rx_disabled'.

Fix by clearing 'inactive' as well.

Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---

Notes:
     Targeting at net-next since this never worked.
     
     Known issues that this patch does not address:
     
     1. Changing 'all_slaves_active' from 1 to 0 while a port is in
        COLLECTING state sets its 'inactive' flag and the port stops
        receiving until the next mux state transition. This is not new,
        COLLECTING is a transient state and the option is off by default, so I
        do not think it is worth handling.
     
     2. The 'inactive' flag shares a bitfield with other slave flags. The
        802.3ad state machine writes them under the mode lock, while the
        'all_slaves_active' handler writes 'inactive' under RTNL only. This is
        not new.

  include/net/bonding.h | 1 +
  1 file changed, 1 insertion(+)
diff --git a/include/net/bonding.h b/include/net/bonding.h
index 598d56b1bc97..cb89aff437f4 100644
--- a/include/net/bonding.h
+++ b/include/net/bonding.h
@@ -594,6 +594,7 @@ static inline void bond_set_slave_active_flags(struct slave *slave,
  static inline void bond_set_slave_rx_enabled_flags(struct slave *slave,
  					       bool notify)
  {
+	slave->inactive = 0;
  	slave->rx_disabled = 0;
  }
  
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
Thread (16 messages) 16 messages, 6 authors, last reply 3d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help