On Wed, 11 Nov 2026 17:41:52 -0800, Jakub Kicinski wrote:
Should the comment in mhi_wwan_ctrl_stop() get the same treatment? The
patch leaves it as is, and it uses the same flush_delayed_work() pattern:
Yes, I missed that one. The flush in stop() makes one attempt like the
one in ->dtr_rts(), and a retry goes out from dtr_work after the channel
has stopped. v2 says so.
A smaller point: the new comment here gives only a full UL ring as the
retry cause. -ENOMEM from kzalloc_obj() in mhi_wwan_ctrl_send_dtr() is
retried the same way. Would it help to mention both, as the comment above
mhi_wwan_ctrl_dtr_work() already does?
Agreed, v2 names both.
Thanks, v2 to follow.