Re: [PATCH net-next 08/15] batman-adv: tt: annotate last_seen with READ/WRITE_ONCE

From
Sven Eckelmann <sven@narfation.org>
Date
2026-11-12 10:58:47
Also in
batman, sashiko-reviews
On Thursday, 12 November 2026 11:34:43 CET sashiko-bot@kernel.org wrote:
[...]
[Severity: High]
This problem wasn't introduced by this patch, but can dropping
common->flags_lock in batadv_tt_local_add_existing() before queueing the
ADD event [1] let a delayed ADD cancel a concurrent DEL event?

batadv_tt_local_add_existing() clears BATADV_TT_CLIENT_PENDING under
common->flags_lock, and its caller batadv_tt_local_add() only queues the
corresponding ADD event via batadv_tt_local_event() after the lock has
been released:
This is handled by a pending patchset [1] which couldn't be submitted here 
because were have so many other things to fix in the TT code and already fill 
our submission up to the max of 15 patchset since a while.

And it is completely irrelevant for the submitted patchset.

Regards,
	Sven

[1] https://git.open-mesh.org/pub/ecsv/batman-adv.git/log/?h=b4/tt-avoid-unhashed-event

Attachments

Thread (1 message) 1 message, 1 author, last reply 1d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help