Re: [PATCH iproute2-next 3/3] tc: flower: add matches psp_spi, psp_ver and psp_dev

From
Stephen Hemminger <stephen@networkplumber.org>
Date
2026-11-12 01:06:20
Also in
linux-kselftest
Reply to
Todd Freed, 2026-11-12
On Wed, 11 Nov 2026 16:15:12 -0800
Todd Freed [off-list ref] wrote:
Match on the PSP Rx state of a packet the device decrypted: the SPI it
was decrypted with (psp_spi, with an optional mask), the PSP version
(psp_ver), and the ID of the PSP device which decrypted it (psp_dev).

For example, to take the packets decrypted with one Rx SPI, from
rx-spi-alloc, and remove their PSP state:

  tc filter add dev eth0 ingress protocol ipv6 flower
      psp_spi 0x80000001 psp_ver 0 psp_dev 1
      action psp decap

These keys only match decrypted packets, even with a zero mask, so
"psp_spi 0/0" matches any decrypted PSP packet.

psp_spi and its mask are hexadecimal, like spi. tc-flower(8) documents
the keys.

Signed-off-by: Todd Freed <redacted>
---
AI review feedback on this


get_u8/get_u32 use base 0 for psp_ver and psp_dev, so "psp_ver 010" is
octal.  The man page documents plain numbers; base 10 would match.
Otherwise this one looks fine.
Thread (8 messages) 8 messages, 2 authors, last reply 3d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help